feat(updater): clear cached installers after update check #9178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c4eddc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment, or this will be closed in 30 days. |
|
@beyondkmp I'm still hesitant on having automatic cleanup up updates. What if we were to open an API that allowed clearing updates programmatically? That would be solving for this issue while avoiding us having to deal with unintended side effects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there's no available update version , then we clear the pending dir to save the disk size.
Tested and confirmed that it can be deleted successfully. Also, when a new version has been downloaded and is in the pending state, checking for updates again will not delete the new version.
Every app checks for updates on startup, and many apps also have a timer that periodically checks for updates in the background. Therefore, performing the deletion during this time should be very appropriate and safe.